[AI Infra] Chat Experience: make Agent default in Elasticsearch Serverless and Solution view by KodeRad · Pull Request #246303 · elastic/kibana

KodeRad · 2025-12-15T08:06:22Z

Summary

Implements: https://github.com/elastic/ml-team/issues/1755
Follow up to: #244532

The goal of this PR is to make Chat Experience in Elasticsearch serverless/solution view default to Agent instead of Classic Assistants.

Implementation details:

Serverless is configured via serverless.es.yml file
Second argument in coreStart.settings.client.get$<AIChatExperience> was removed as it was overriding provided configuration.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

elasticmachine · 2025-12-15T08:19:09Z

Pinging @elastic/ml-ui (:ml)

elasticmachine · 2025-12-15T08:19:11Z

Pinging @elastic/appex-ai-infra (Team:AI Infra)

rbrtj · 2025-12-15T08:46:14Z

+            if (request) {
+              try {
+                const [, startServices] = await core.getStartServices();
+                const spaces = (startServices as { spaces?: SpacesPluginStart }).spaces;


We can get rid of this type assertion by properly typing AIAssistantManagementSelectionPluginServerDependenciesStart in src/platform/plugins/shared/ai_assistant_management/selection/server/types.ts

Thanks. That's definitely an improvement! Fixed here b0792c8

github-actions · 2025-12-15T08:46:28Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

e40pud

Security GenAI code LGTM

gsoldevila · 2025-12-15T10:21:11Z

+# AI Assistant Management Selection plugin
+aiAssistantManagementSelection.preferredChatExperience: 'classic'
+


IIUC this configuration is unnecessary as this is already the default value for the setting.

I checked that and it's indeed redundant. Fixed here 0d42f63

joemcelroy · 2025-12-15T10:29:08Z

could you remove this label please? (default) This can be done everywhere.

KodeRad · 2025-12-15T11:08:06Z

@joemcelroy

could you remove this label please? (default) This can be done everywhere.

It is part of a separate PR ✅

gsoldevila

Core changes LGTM!

rbrtj

LGTM 💯

… unnecessary log errors before login

elasticmachine · 2025-12-15T21:51:45Z

⏳ Build in-progress

Buildkite Build
Commit: e08e4d9
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-246303-e08e4d93942c

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #100 / Endpoint plugin @ess @serverless @skipInServerlessMKI Endpoint artifacts (via lists plugin): Trusted Applications "before all" hook in "@ess @serverless @skipInServerlessMKI Endpoint artifacts (via lists plugin): Trusted Applications"

History

💛 Build #373067 was flaky 0d42f63

cc @KodeRad

jgowdyelastic · 2025-12-16T08:59:54Z

+              try {
+                const [coreStart, startServices] = await core.getStartServices();
+                // Avoid security exceptions before login
+                const user = coreStart.security.authc.getCurrentUser(request);


You could also use request.auth.isAuthenticated rather than fetching the user.
I don't know which approach is preferred.

That's good catch! I will address that in following PR

jgowdyelastic

Added a minor comment about not really needing to fetch the user.
but otherwise LGTM

make agent as default in es serverless and solution view

9d5e9d6

KodeRad self-assigned this Dec 15, 2025

KodeRad added release_note:enhancement :ml backport:skip This PR does not require backporting Team:ML Team label for ML (also use :ml) t// Team:AI Infra Platform AppEx AI Infrastructure Team t// labels Dec 15, 2025

KodeRad requested a review from rbrtj December 15, 2025 08:08

KodeRad marked this pull request as ready for review December 15, 2025 08:19

KodeRad requested review from a team as code owners December 15, 2025 08:19

KodeRad requested a review from jgowdyelastic December 15, 2025 08:19

rbrtj reviewed Dec 15, 2025

View reviewed changes

botelastic Bot added the ci:project-deploy-observability Create an Observability project label Dec 15, 2025

KodeRad added the v9.3.0 label Dec 15, 2025

e40pud approved these changes Dec 15, 2025

View reviewed changes

pgayvallet approved these changes Dec 15, 2025

View reviewed changes

add explicit types and remove type assertion

b0792c8

KodeRad requested a review from rbrtj December 15, 2025 10:19

gsoldevila reviewed Dec 15, 2025

View reviewed changes

joemcelroy approved these changes Dec 15, 2025

View reviewed changes

SiddharthMantri self-requested a review December 15, 2025 11:22

remove redundant setting from serverless.yml

0d42f63

KodeRad requested a review from gsoldevila December 15, 2025 11:31

KodeRad changed the title ~~[AI Infra] Chat Experience: make Agent default in Search Serverless and Solution view~~ [AI Infra] Chat Experience: make Agent default in Elasticsearch Serverless and Solution view Dec 15, 2025

viduni94 approved these changes Dec 15, 2025

View reviewed changes

gsoldevila approved these changes Dec 15, 2025

View reviewed changes

SiddharthMantri approved these changes Dec 15, 2025

View reviewed changes

rbrtj approved these changes Dec 15, 2025

View reviewed changes

fix: documentationSection display on elasticsearch serverless; remove…

e08e4d9

… unnecessary log errors before login

jgowdyelastic reviewed Dec 16, 2025

View reviewed changes

jgowdyelastic approved these changes Dec 16, 2025

View reviewed changes

KodeRad merged commit 3c6be51 into elastic:main Dec 16, 2025
13 checks passed

peteharverson added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Dec 16, 2025

		# AI Assistant Management Selection plugin
		aiAssistantManagementSelection.preferredChatExperience: 'classic'

Conversation

KodeRad commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Identify risks

Uh oh!

elasticmachine commented Dec 15, 2025

Uh oh!

elasticmachine commented Dec 15, 2025

Uh oh!

rbrtj Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

KodeRad Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Dec 15, 2025

🤖 GitHub comments

Uh oh!

e40pud left a comment

Choose a reason for hiding this comment

Uh oh!

gsoldevila Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

KodeRad Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

joemcelroy commented Dec 15, 2025

Uh oh!

KodeRad commented Dec 15, 2025

Uh oh!

gsoldevila left a comment

Choose a reason for hiding this comment

Uh oh!

rbrtj left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Dec 15, 2025

⏳ Build in-progress

Failed CI Steps

Test Failures

History

Uh oh!

jgowdyelastic Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

KodeRad Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

KodeRad commented Dec 15, 2025 •

edited

Loading